[FIX] l10n_uy_edi: move type when creating cfe from xml#403
Closed
pablohmontenegro wants to merge 1 commit intoingadhoc:16.0from
Closed
[FIX] l10n_uy_edi: move type when creating cfe from xml#403pablohmontenegro wants to merge 1 commit intoingadhoc:16.0from
pablohmontenegro wants to merge 1 commit intoingadhoc:16.0from
Conversation
Ticket: 112422
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Fixes vendor-bill sync from Uruware notifications by avoiding a crash when the derived move_type is missing while deciding whether to create an account.move from the received XML.
Changes:
- Store the computed
move_typein a variable before checking it. - Guard the
'in_' in move_typecheck to avoid errors whenmove_typeis falsy/None.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
@roboadhoc r+ nobump |
roboadhoc
pushed a commit
that referenced
this pull request
Mar 19, 2026
closes #403 Ticket: 112422 Signed-off-by: Victoria Halac - hav (#l10n) <hav@adhoc.inc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: 112422