Support CSV column headers written unquoted#63
Merged
Conversation
acoulton
requested changes
Mar 10, 2025
Member
acoulton
left a comment
acoulton
left a comment
There was a problem hiding this comment.
Implementation looks good, just a couple thoughts
craig410
force-pushed
the
support-csv-unquoted-column-headers
branch
from
75b83c8 to
0fbb495
Compare
acoulton
approved these changes
Mar 10, 2025
Member
acoulton
left a comment
acoulton
left a comment
There was a problem hiding this comment.
LGTM if you can revert to a phpdoc typehint
craig410
force-pushed
the
support-csv-unquoted-column-headers
branch
from
8776074 to
780d80a
Compare
Only causes it to become disabled when there aren't regular pushes and then the tests don't run until you manually enable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.