Skip to content

Support CSV column headers written unquoted #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

craig410
Copy link
Member

No description provided.

@craig410 craig410 requested a review from acoulton March 10, 2025 11:47
Copy link
Member

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just a couple thoughts

@craig410 craig410 force-pushed the support-csv-unquoted-column-headers branch from 75b83c8 to 0fbb495 Compare March 10, 2025 12:02
@craig410 craig410 requested a review from acoulton March 10, 2025 12:02
Copy link
Member

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you can revert to a phpdoc typehint

@craig410 craig410 force-pushed the support-csv-unquoted-column-headers branch from 8776074 to 780d80a Compare March 10, 2025 12:13
Only causes it to become disabled when there aren't regular pushes and then the tests don't run until you manually enable it.
@craig410 craig410 merged commit 9953e12 into 2.x Mar 10, 2025
4 checks passed
@craig410 craig410 deleted the support-csv-unquoted-column-headers branch March 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants