feat: AddImplicitVoidInterfaceReturnTypeRector - #4
Merged
Conversation
This new rule will add explicit `void` return types to interface methods that do not document a return type. Methods that already have a phpdoc return type (including `@return void`) or a strict return type will not be affected. This rule is needed because `AddReturnTypeFromPhpDocRector` intentionally doesn't add return types if the phpdoc does not specify the `@return`. In many projects the absence of a `@return` tag on an interface means that the method does not return - but it can also be a mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new rule will add explicit
voidreturn types to interface methods that do not document a return type.Methods that already have a phpdoc return type (including
@return void) or a strict return type will not be affected.This rule is needed because
AddReturnTypeFromPhpDocRectorintentionally doesn't add return types if the phpdoc does not specify the@return.In many projects the absence of a
@returntag on an interface means that the method does not return - but it can also be a mistake.