fix: Convert phpdoc union types to strict types - #6
Merged
Conversation
The phpdoc to param / return / property type rectors were not processing union types (e.g. `string|null` or `int|false|string`. We should be able to convert these, assuming that we can resolve a strict type for all the types in the union.
acoulton
force-pushed
the
fix-union-types
branch
from
April 17, 2026 21:55
8264de4 to
24df446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phpdoc to param / return / property type rectors were not processing union types (e.g.
string|nullorint|false|string.We should be able to convert these, assuming that we can resolve a strict type for all the types in the union.