Implement SimpleBuildStep #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Theoretically, it should be a publisher. I'll review it and get back to you in a few weeks ok? |
|
Please, what is the status of this task? |
|
No status |
|
ok, but will be implemented? |
|
It it makes sense. Internally, its a hack so it needs proper evaluation. You're free to try the patch and use it locally Thank you |
|
Hello, any updates on this ? We are stuck with freestyle jobs because we use AWS Eb deployments. |
crisp2u
reviewed
Jul 20, 2017
| } | ||
|
|
||
| public boolean perform() throws Exception { | ||
| AWSEBDeploymentConfig | ||
| deploymentConfig = | ||
| deploymentBuilder.asConfig().replacedCopy(new Utils.Replacer(build, listener)); | ||
| deploymentBuilder.asConfig();//.replacedCopy(new Utils.Replacer(build, listener)); |
There was a problem hiding this comment.
@bmtKIA6 Is there a reason for changing the substitution code ? I tested your patch but now the application version does lost variable replacement functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the migration guidelines, quick and dirty attempt to implement SimpleBuildStep
https://jenkins.io/blog/2016/05/25/update-plugin-for-pipeline/