[drain] would loop infinitely if no bytes were currently pending. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dhouse-js wants to merge 1 commit into inhabitedtype:master from dhouse-js:fix-infinite-loop-in-drain

Contributor

dhouse-js commented Jun 25, 2021

This PR fixes this and adds some tests for the [drain] function.


          [drain] would loop infinitely if no bytes were currently pending.

4cad615

This PR fixes this and adds some tests for the [drain] function.

Member

seliopou commented Jul 5, 2021

It might be better just rename this close_and_drain and perform the close at the top of the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet