Skip to content

feat: add block number property to BuiltBlock #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

feat: add block number property to BuiltBlock #59

merged 4 commits into from
May 29, 2025

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented May 23, 2025 •
edited
Loading

feat: add block number property to BuiltBlock

This PR adds a block number field and a setter for tracking the block number of a given built block.

@dylanlott Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott changed the title logs feat: add block number property to BuiltBlock May 23, 2025
@dylanlott dylanlott force-pushed the dylan/block-number branch from 8c2d655 to bbf83ce Compare May 23, 2025 17:07
@dylanlott dylanlott mentioned this pull request May 23, 2025
Merged
@dylanlott dylanlott self-assigned this May 23, 2025
@dylanlott dylanlott marked this pull request as ready for review May 23, 2025 20:44
@dylanlott dylanlott requested a review from a team as a code owner May 23, 2025 20:44
@dylanlott dylanlott force-pushed the dylan/block-number branch 2 times, most recently from abb43fd to 22ec3e8 Compare May 27, 2025 18:53
prestwich
prestwich reviewed May 28, 2025
View reviewed changes
prestwich
prestwich reviewed May 28, 2025
View reviewed changes
prestwich
prestwich reviewed May 28, 2025
View reviewed changes
prestwich
prestwich reviewed May 28, 2025
View reviewed changes
@dylanlott dylanlott force-pushed the dylan/block-number branch from 23d5578 to e35c0be Compare May 28, 2025 18:04
@dylanlott dylanlott force-pushed the dylan/block-number branch from e35c0be to f0b6ed0 Compare May 28, 2025 18:05
@prestwich
Copy link
Member

just lint

@dylanlott Graphite App
Copy link
Contributor Author

Cool, fixed lints and nits, but this branch currently drops the revm and alloy update commit in history, so the PR will need to be rebased appropriately before merging once the builder is updated. Keeping this open for testing in the meantime.

@dylanlott dylanlott merged commit ba5894f into main May 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees

@dylanlott dylanlott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @prestwich