-
Notifications
You must be signed in to change notification settings - Fork 205
Fix traverseFiles to only process files, not directories #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant T as traverseFiles
participant E as Directory Entry
participant C as Callback
T->>E: Read next directory entry
alt Entry is a File
T->>C: Invoke callback with file path
else Entry is a Directory
T->>T: Recursively traverse directory
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixed a logical error in traverseFiles.ts where the callback function was executed for both files and directories.
The function now correctly processes only files, as suggested by its name and documentation.
This prevents potential errors in JSON processing and image optimization that rely on this utility.
Summary by CodeRabbit