-
Notifications
You must be signed in to change notification settings - Fork 210
add eINIT #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add eINIT #766
Conversation
WalkthroughA new asset entry for the Cabal eINIT token was added to the echelon asset registry. The entry includes denomination units, IBC trace information via channel-35 to the Initia chain, and associated metadata including name, symbol, and logo URLs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
mainnets/echelon/assetlist.json (1)
439-447: Consider reordering denom_units for consistency.The
denom_unitsarray has the display denomination (exponent 6) listed before the base denomination (exponent 0). While this matches the sxINIT entry (also a Cabal token), it's inconsistent with 7 out of 9 asset entries in this file, where the base denomination (exponent 0) is listed first.🔎 Suggested reordering for consistency
"denom_units": [ { - "denom": "eINIT", - "exponent": 6 + "denom": "ibc/749ECC13174B58CB9BFED2C8608670DBD3AF3EFE767E8AE671C1AFFB97F75116", + "exponent": 0 }, { - "denom": "ibc/749ECC13174B58CB9BFED2C8608670DBD3AF3EFE767E8AE671C1AFFB97F75116", - "exponent": 0 + "denom": "eINIT", + "exponent": 6 } ],
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
images/eINIT.pngis excluded by!**/*.png
📒 Files selected for processing (1)
mainnets/echelon/assetlist.json
🧰 Additional context used
🪛 GitHub Actions: check pre-commit
mainnets/echelon/assetlist.json
[error] 434-434: Prettier formatting check failed. Run 'prettier --write' to fix code style issues in this file.
🔇 Additional comments (1)
mainnets/echelon/assetlist.json (1)
469-476: eINIT.png file is present in the repository.The image file exists at
./images/eINIT.pngand is correctly referenced in the assetlist.json.
| }, | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the formatting issue to pass the pre-commit check.
The pipeline failure indicates a Prettier formatting issue. The opening brace at line 437 appears to have incorrect indentation.
Run the following command to automatically fix the formatting:
prettier --write mainnets/echelon/assetlist.json🤖 Prompt for AI Agents
In mainnets/echelon/assetlist.json around lines 436 to 437, there is a Prettier
formatting issue: the opening brace on line 437 has incorrect indentation; fix
by running the auto-formatter (prettier --write mainnets/echelon/assetlist.json)
or manually adjust indentation so the brace aligns with the surrounding JSON
structure and re-run pre-commit to ensure the file passes formatting checks.
adds cabal INIT on echelon with icon and name provided by the echelon team
Summary by CodeRabbit
New Features
✏️ Tip: You can customize this high-level summary in your review settings.