Conversation
Member
Author
|
Leaving this open temporarily, but TL;DR this is a bad idea and I'm wrapping up a branch that makes tradeoffs that are way less scary (but now it needs some cherry-picking after the past PR) |
Draft
Member
Author
|
This was a bad approach. We knew that we wanted to use things like the WebCrypto API for non-extractable keys — abstracting over this allows people to hook logs and whatever else in (but to be crystal clear DO NOT LOG GENERATED PRIVATE KEYS) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
TL;DR right now Beelay uses a WAL for durability reasons, rather than the heavier operation of serialising to an
keyhive_core::Archive. In the current Keyhive implementation, this means that we lose our own secrets if there's a crash. This PR adds a new listener on X25519 keypair generation.