E2E demo deps #80
Draft
E2E demo deps #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expede
commented
Jan 31, 2025
|
|
||
| let round_tripped = bob | ||
| .try_decrypt_content(bob_doc1.dupe(), &encrypted_content) | ||
| .unwrap(); |
There was a problem hiding this comment.
@jtfmumm this panics. I think that lines 1471-1476 show that the CGKAs should be in sync. Maybe the receive is missing a rebuild trigger or something?
expede
commented
Jan 31, 2025
| } | ||
| StaticEvent::PrekeyRotated(op) => self.receive_prekey_op(&KeyOp::from(Rc::new(op)))?, | ||
|
|
||
| StaticEvent::CgkaOperation(cgka_op) => self.receive_cgka_op(cgka_op)?, |
There was a problem hiding this comment.
This is the Cgka op coming in off the wire
expede
commented
Jan 31, 2025
keyhive_core/src/keyhive.rs
Outdated
Comment on lines
1478
to
1481
| assert_eq!( | ||
| alice_doc1.borrow().cgka.pcs_key_ops, | ||
| bob_doc1.borrow().cgka.pcs_key_ops | ||
| ); |
There was a problem hiding this comment.
Perhaps worth noting that these are different (this assertion fails)
There was a problem hiding this comment.
This makes sense, since Bob would only insert into this once he has decrypted the root secret and created a PcsKey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.