Remote cursors pvh #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tee-production ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for tangerine-dolphin-eefe36 failed.
|
pvh
commented
Feb 2, 2024
|
|
||
| const handleReady = handle.isReady(); | ||
|
|
||
| const account = useCurrentAccount(); |
There was a problem hiding this comment.
PS: this hook is driving me crazy
There was a problem hiding this comment.
specifically, it's annoying that i have to check several levels of hierarchy (account, currentaccount, doc) and then i still have the type / anonymous stuff where if the type is anonymous i have to reinvent the name & a color every time...
my suggestion is that we set the name to anonymous (at least in the hook but i think in the doc too) and pick a random presence color and leave it on the contact doc.
|
Is this ready to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulsonnentag here's ... most of a patch to implement remote cursors & selection sharing (I was annoyed yesterday that I didn't have it). It's still a bit rough but it's close. I seem to be sharing the selection data and creating decorations but something goes wrong in rendering and I go into an infinite loop on both peers. LMK if you see something obviously wrong or just wait and I'll fix it.