Skip to content

Revert #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: patchwork
Choose a base branch
from
Open

Revert #63

wants to merge 59 commits into from

Conversation

paulsonnentag
Copy link
Collaborator

@paulsonnentag paulsonnentag commented Jun 3, 2024 •
edited
Loading

Add back option to revert changes. This is a follow up on #59

  • datatypes need to add invert patches to annotations so edits can be inverted (eventually, we should push this down into automerge)
  • essay data type has some diff normalization to filter out redundant insert / delete operations

Todos:

  • add keyboard shortcut
  • revert on deleted shapes in tldraw doesn't work
  • fix edge cases in diff normalization
  • fix type errors

@paulsonnentag
hide comment highlights if timeline sidebar is open
de3c038
@paulsonnentag
reset history state when switching to review mode
6c43b9c
@paulsonnentag
create a valid range when trying to comment on the end of the document
8a0215d
@paulsonnentag
filter out comments on empty ranges
e012520
@paulsonnentag
add global keyboard shortcut cmd+m+shift to comment
622ea3b
@paulsonnentag
handle setSelectedAnchors if selection is not a range
0b111cb
@paulsonnentag
fix stale annotations in hook
9e134f5
@paulsonnentag
Add general comments without anchors above all other comments
75ae3f8
@paulsonnentag
fix boundary check
4786d1b
@paulsonnentag
don't render duplicate hightlight + added annotation when commenting …
106e638 
…on edits
@paulsonnentag
allow to use markdown in comments
b47da99
@paulsonnentag
Render markdown comments
a070345
@paulsonnentag
support images in comments
b30c27c
@paulsonnentag
WIP: add back inline comments for tee
56d3f1a
@paulsonnentag
hide inline comments when sidebar is open
9cd72f4
@paulsonnentag
tweak styling
51a117f
@paulsonnentag
handle hover state
4952249
@paulsonnentag
tweak styling
7b1f509
@paulsonnentag
move resolve logic into AnnotationGroupView
c424a0b
@paulsonnentag
allow to edit own comments
777765a
@paulsonnentag
fix click handler
405180f
@paulsonnentag
hoist up comment edit state to VersionControlEditor
81e67da
@paulsonnentag
Allow to reply to comments
b0ddc33
@paulsonnentag
Add comment button
e3fffce
@paulsonnentag
create pending discussion group when comment is added on new range
f8eaf77
@paulsonnentag
hide comment button if editor is not focused
cf8ed43
@paulsonnentag
allow to comment on end of document
d6eeee5
@paulsonnentag
Add comment button in sidebar
82cf2fc
@paulsonnentag
replace edit/create comment with setCommentState
70523cb
@paulsonnentag
fix global comments
737980a
@paulsonnentag
stop navigation key presses from bubbling up
de2b382
@paulsonnentag
Fix adding replies
dfd480c
@paulsonnentag
fix keyboard shortcuts
29a8a91
@paulsonnentag
fix filter out resolved discussions
ea5d72d
@paulsonnentag
adjust estimatedHeightOfAnnotationGroups function
8f78944
@paulsonnentag
tweak styling
df233ba
@paulsonnentag
codemirror: avoid triggering redundant events
f7bb647 
ensure codemirror only triggers selectedAnchor changes if the selection changed
@paulsonnentag
fix global add coment keyboard shortcut
ed5ca1f
@paulsonnentag
show comments without anchors always on top
d925c55
@paulsonnentag
render whitespaces in essay annotations correctly
9c45b6f
@paulsonnentag
fix commenting on edits
555fa18
@paulsonnentag
don't filter out annotations at beginning of text
f69dd01
@paulsonnentag
cleanup higlight renders in EssayAnnotations view
5771f6d
@paulsonnentag
fix side by side
a8500a2
@paulsonnentag
only highlight sidebar button for datatypes without inline comments
b518caf
@paulsonnentag
fix type errors
7b1225e
@paulsonnentag
fix view branch button
50e224b
@paulsonnentag
fix accesing property on undefined
e05e2d5
@paulsonnentag
add naive invert
68c605c 
- add invert patches to annotations
@paulsonnentag
normalize redundant patches in essay
a7609b9
@paulsonnentag
fix offset bugs
5665824
@paulsonnentag
When normalizing an insert followed by a delete try to display it as …
2c8261c 
…a full word replacement
@paulsonnentag
handle complete overlaps correctly
3ac26c5
@paulsonnentag
try to create full word replacements when normalizing changes with ov…
0e87a82 
…erlap end
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

❌ Deploy Preview for tee-production failed.

Name Link
🔨 Latest commit 5d92a28
🔍 Latest deploy log https://app.netlify.com/sites/tee-production/deploys/665f023724a32400083962d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@paulsonnentag