ci: check formatting instead of rewriting files - #638
Open
leonschh wants to merge 1 commit into
Open
Conversation
Update the formatting CI job to validate formatting instead of rewriting files. Replace pnpm run format:js with pnpm run format:js:check. format:js uses Prettier --write, which modifies files instead of validating them. format:js:check uses Prettier --check and fails when formatting differs. format:js:check is already defined in package.json and is used by the main lint script. This ensures the CI formatting job acts as a validation gate instead of silently rewriting files inside the runner.
Author
|
I wrote about this line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the formatting CI job to validate formatting instead of rewriting files.
pnpm run format:jswithpnpm run format:js:chec.format:jsuses Prettier--write, which modifies files instead of validating them.format:js:checkuses Prettier--checkand fails when formatting differs.format:js:checkis already defined inpackage.jsonand is used by the mainlintscript.This ensures the CI formatting job acts as a validation gate instead of silently rewriting files inside the runner.