WIP: macOS new UI #56
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 3
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
morajabi
force-pushed
the
new-tabs-side-custom-layout
branch
from
0963e40 to
2b337a9
Compare
| } | ||
|
|
||
| saveStateLowPriority() | ||
| } |
There was a problem hiding this comment.
Bug: History not updated after tab removal
The removeTab function adjusts activeTabIndex when a tab is removed but doesn't update the navigation history or call activateTab to synchronize state. After removing a tab, currentRoute and activeSpaceId may return stale values from the history that reference the removed tab or wrong tab, causing navigation inconsistencies. The function should call activateTab after adjusting the index to properly update history.
morajabi
force-pushed
the
new-tabs-side-custom-layout
branch
from
c6e3140 to
6ca8945
Compare
| log.trace("Navigating to \(route)") | ||
| lastRoutes[activeTab] = route | ||
| history.append(Nav2Entry(route: route, tab: activeTab)) | ||
| } |
There was a problem hiding this comment.
Bug: Forward history not cleared on navigation
The navigate(to:) function appends to history but doesn't clear forwardHistory. This breaks standard browser-like navigation behavior where navigating to a new route should invalidate the forward history stack. Compare with activateTab which correctly clears forwardHistory on line 208 when adding new history entries. Users may experience unexpected behavior if they navigate backward, then to a new route, and try to go forward again.
morajabi
force-pushed
the
new-tabs-side-custom-layout
branch
2 times, most recently
from
4d44fde to
ab9699c
Compare
morajabi
force-pushed
the
new-tabs-side-custom-layout
branch
from
ab9699c to
2a7b69f
Compare
morajabi
force-pushed
the
new-tabs-side-custom-layout
branch
from
89b5bde to
8905c21
Compare
Note
Overhauls the macOS app UI with a new window stack, tabbed spaces navigation, revamped sidebar, and a persistent Nav2 router, replacing legacy controllers.
MainWindowController,MainWindowView,MainWindowBg, andMainSplitViewwith separatetabsArea,sideArea, andcontentArea.MainTabBar,TabCollectionViewItem,TabCloseOverlayView,TabSurfaceButton, and helpers; supports dynamic sizing, closeable tabs (except Home), and a Spaces menu with avatar initials.MainSidebar,MainSidebarList,MainSidebarHeaderView, and item cell/collection item with diffable data source, unread/pin badges, and context actions.Nav2(tabs, routes, history, persistence) andMainSplitView+Routesfor view resolution; integratesnav2intoAppDependenciesand usage across views; disables legacyNavigationModel.setUpForRoutehook.PlaceholderContentViewControllerandinline-logo-bgasset.AppDelegateto use newMainWindowController, refined delegate signatures, notification/URL handling; enablesNSObservationTrackingEnabledinInfo.plist.ChatIconSwiftUIBridgeconstraints.Windows/MainWindowController.swift; comments out legacy split-view controller.Theme.MACOSX_DEPLOYMENT_TARGETto15.2in project settings.Written by Cursor Bugbot for commit 4d44fde. This will update automatically on new commits. Configure here.