Include unit of returned value #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheFRedFox
approved these changes
Jul 25, 2019
Contributor
TheFRedFox
left a comment
TheFRedFox
left a comment
There was a problem hiding this comment.
Code is surely correct. ^^
Just semantic question: What made it important now to change it to explicitly KiB?
TuxPowered42
force-pushed
the
libvirt_units
branch
3 times, most recently
from
8daf7b2 to
ef97af6
Compare
TuxPowered42
force-pushed
the
libvirt_units
branch
from
ef97af6 to
e16aa94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.