Skip to content

Ensure selection of fallback instance type if necessary #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konstantinbest wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure selection of fallback instance type if necessary #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions igvm/vm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,9 +659,9 @@ def aws_build(self,
"""

vm_types_overview = self.aws_get_instances_overview()
if vm_types_overview:
Copy link
Member

@v0devil v0devil Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems aws_get_instances_overview can return None, and then there is iteration aws_get_fitting_vm_types through overview var which can be None and then probably lead to TypeError.

vm_types = self.aws_get_fitting_vm_types(vm_types_overview)
else:
vm_types = self.aws_get_fitting_vm_types(vm_types_overview)

if not vm_types:
vm_types = [AWS_FALLBACK_INSTANCE_TYPE]

root_device = list(
Expand Down