feat(outlook): support explicit shared mailbox users - #314
Draft
kai-osthoff wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.usersupport for shared or delegated mailbox UPNs and Entra object IDs/mepaths and legacy calendar hashes when the option is absentCalendars.ReadWrite.Sharedin the handler-owned authorization URLValidation
go test ./internal/adapter/outlook_http ./internal/adapter -race -count=1make testgo vet $(go list ./... | grep -v /vendor/)go run honnef.co/go/tools/cmd/staticcheck@2025.1.1 ./...go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.5.0 runmake build/meand escaped/users/{user}paths across list/create/update/deleteReal Graph check
Redacted local dry-runs exercised both normal-user and explicit Shared Mailbox configurations using temporary config/auth copies; production bridge files were not changed. The pre-feature cached token can reach delegated calendar data but Graph returns
ErrorAccessDeniedfor Shared Mailbox writes and extension expansion. A controlled test event was removed after every attempt, leaving no residue.The PR is draft until the delegated account completes interactive authorization for the newly requested
Calendars.ReadWrite.Sharedscope and the controlled create/update/delete checks in both directions finish at0/0/0.Closes #313