fix: export domain info metrics for all domain states#94
Open
ADometrius wants to merge 1 commit intoinovex:masterfrom
Open
fix: export domain info metrics for all domain states#94ADometrius wants to merge 1 commit intoinovex:masterfrom
ADometrius wants to merge 1 commit intoinovex:masterfrom
Conversation
Collaborator
|
@ADometrius Do you mind opening an issue including some example cases? |
Previously, libvirt_domain_info_state and related info metrics were only exported for running domains. This was because DomainGetInfo() fails for inactive domains, causing the CollectDomain function to exit early before emitting any metrics. This change ensures that domain info and state metrics are always exported regardless of domain state by: 1. Moving domain info metric emission before DomainGetInfo() call 2. Adding graceful fallback to DomainGetState() when DomainGetInfo() fails 3. Always emitting libvirt_domain_info_state for complete domain visibility Now users can monitor all domains (running, stopped, paused, crashed, etc.) and get proper domain state information for inventory and alerting purposes. Fixes missing metrics for inactive domains while preserving existing behavior for performance metrics that only apply to running domains. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
@ADometrius could you kindly give an update on this PR and my question #94 (comment)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, libvirt_domain_info_state and related info metrics were only exported for running domains. This was because DomainGetInfo() fails for inactive domains, causing the CollectDomain function to exit early before emitting any metrics.
This change ensures that domain info and state metrics are always exported regardless of domain state by:
Now users can monitor all domains (running, stopped, paused, crashed, etc.) and get proper domain state information for inventory and alerting purposes. This is critical to close gaps in monitoring where domain state could represent and alert threshold
Fixes missing metrics for inactive domains while preserving existing behavior for performance metrics that only apply to running domains.
Co-Authored-By: Claude noreply@anthropic.com