Update Dockerfile and CI configuration to avoid SecretsUsedInArgOrEnv docker warning for DIRECTUS_TOKEN - #356
Merged
Conversation
Planlos5000
reviewed
Mar 16, 2026
jmoehler
enabled auto-merge
June 17, 2026 12:51
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
…orrect position to enable more efficient caching
Planlos5000
reviewed
Aug 5, 2026
Collaborator
There was a problem hiding this comment.
Maybe we could also update our .dockerignore to also include files and folders that are created when building the page locally or are not needed in the docker context.
Here a list of what could be part of the .dockerignore (it could be that this list is not complete):
.astrodist.env.env.example- code of conduct, readme and licese
Planlos5000
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
Dockerfile: mount directus token as secret instead of arg, cleaning it
CI: set the token as secret instead of build-arg
Readme: adjusted documentation accordingly