feat: cancel voting (frontend) - #6465
Open
mating02 wants to merge 4 commits into
Open
Conversation
5 tasks
mating02
marked this pull request as ready for review
August 10, 2026 12:24
mating02
force-pushed
the
feat/mg/cancel-voting-backend-6396
branch
from
August 10, 2026 12:37
ab9ee48 to
b93e843
Compare
mating02
force-pushed
the
feat/mg/cancel-voting-frontend-6396
branch
from
August 10, 2026 12:46
b07c1ce to
ebf82ab
Compare
mating02
added
Review Needed
Planlos5000
reviewed
Aug 11, 2026
Comment on lines
+30
to
+42
| changeVotingStatus: async (board: string, voting: string, status?: string) => { | ||
| try { | ||
| const response = await fetch(`${SERVER_HTTP_URL}/boards/${board}/votings/${voting}`, { | ||
| const options: RequestInit = { | ||
| method: "PUT", | ||
| credentials: "include", | ||
| }); | ||
| }; | ||
|
|
||
| if (typeof status !== "undefined") { | ||
| options.body = JSON.stringify({status}); | ||
| options.headers = {"Content-Type": "application/json"}; | ||
| } | ||
|
|
||
| const response = await fetch(`${SERVER_HTTP_URL}/boards/${board}/votings/${voting}`, options); |
Collaborator
There was a problem hiding this comment.
I think the status should always be set and should not be able to undefined or null. Also use the VotingStatus type
Comment on lines
+49
to
+52
| const abortVoting = () => { | ||
| dispatch(cancelVoting(voting!)); | ||
| navigate(".."); | ||
| } |
Collaborator
There was a problem hiding this comment.
We should be consistent with the naming. Is it now abort or cancel?
mating02
force-pushed
the
feat/mg/cancel-voting-backend-6396
branch
from
August 12, 2026 12:03
b93e843 to
772d388
Compare
mating02
force-pushed
the
feat/mg/cancel-voting-frontend-6396
branch
2 times, most recently
from
August 12, 2026 12:07
ac1ba8d to
619ec6d
Compare
mating02
force-pushed
the
feat/mg/cancel-voting-frontend-6396
branch
from
August 17, 2026 09:01
393a10d to
7776c8b
Compare
mating02
force-pushed
the
feat/mg/cancel-voting-backend-6396
branch
from
August 17, 2026 09:01
568dfa4 to
fdd8eee
Compare
Schwehn42
requested changes
Aug 17, 2026
| <label>{t("VoteConfigurationButton.stopVoting")}</label> | ||
| </button> | ||
|
|
||
| <button className="voting-dialog__start-button voting-dialog__cancel-button" data-testid="voting-dialog__cancel-button" onClick={() => abort_voting()}> |
Member
There was a problem hiding this comment.
should be "abort" instead of "cancel"
| navigate(".."); | ||
| }; | ||
|
|
||
| const abort_voting = () => { |
Member
There was a problem hiding this comment.
snake case‽ this ain't python
| }, | ||
|
|
||
| changeVotingStatus: async (board: string, voting: string) => { | ||
| changeVotingStatus: async (board: string, voting: string, status?: VotingStatus) => { |
| changeVotingStatus: async (board: string, voting: string, status?: VotingStatus) => { | ||
| try { | ||
| const response = await fetch(`${SERVER_HTTP_URL}/boards/${board}/votings/${voting}`, { | ||
| const options: RequestInit = { |
Member
There was a problem hiding this comment.
I'd prefer the options inline inside the fetch rather than an extra object, since we do it that way in all other places (not to say this is bad, I just want it to be the same if possible)
| method: "PUT", | ||
| credentials: "include", | ||
| }); | ||
| body: JSON.stringify({ status: status }), |
Member
There was a problem hiding this comment.
properties with the same name and value can be shortened like this: {status}
|
|
||
| await retryable( | ||
| () => API.changeVotingStatus(boardId, payload), | ||
| () => API.changeVotingStatus(boardId, payload, "CLOSED"), |
Member
There was a problem hiding this comment.
should be "ABORT(ED)" here also
Schwehn42
added
Changes Requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented a new button right beneath the stop voting button that uses the backend cancel feature to stop the voting without evaluation.
Changelog
Checklist
Visual Changes
Stack created with GitHub Stacks CLI • Give Feedback 💬