fix: keep banned participants visible after reload, auto-rejoin on unban - #6521
Open
jmoehler wants to merge 3 commits into
Open
fix: keep banned participants visible after reload, auto-rejoin on unban#6521jmoehler wants to merge 3 commits into
jmoehler wants to merge 3 commits into
Conversation
Closes #4738. - Participants.tsx: include banned participants in the list regardless of the connected/online filter, so a moderator can still reach the unban button after reloading the page (banned sessions are persisted as connected=false, which previously caused them to disappear). - RejectionPage.tsx: when a user lands here with status="banned" and a boardId in the URL, silently probe the join endpoint every 30 seconds and surface a "Try to rejoin" button. On a successful re-admission the page dispatches permittedBoardAccess and the board mounts without a manual refresh. Probing goes through API.joinBoard directly instead of the joinBoard thunk so a still-banned response does not flip the redux status to pending and unmount the rejection page. - i18n (en/de/fr): added bannedRetryHint, retry, retrying. - styles: button group + retry button styling, dark mode respected.
jmoehler
added
Review Needed
Collaborator
Author
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6521.development.scrumlr.fra.ics.inovex.io Deployed Images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we didn't hear back from https://github.com/Phai2o on #6127, we took it in our own hands to finish the mr.
This is now the updated mr, containing the original changes puls updated snapshots and rebase on current main.