Skip to content

fix: unauthorized get templates fetch #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Schwehn42 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: unauthorized get templates fetch #6527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d55295
fix: rm duplicate template fetch
Schwehn42 Aug 19, 2026
7ccf4c5
fix: only fetch custom templates if allowed
Schwehn42 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/routes/Boards/Boards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import {useTranslation} from "react-i18next";
import {Outlet, useLocation, useNavigate} from "react-router";
import {useEffect, useState} from "react";
import {useState} from "react";
import {Input} from "components/Input/Input";
import {HeaderBar} from "components/HeaderBar";
import classNames from "classnames";
import {getTemplates} from "store/features";
import {useAppDispatch, useAppSelector} from "store";
import {useAppSelector} from "store";
import {ImportBoard, ImportBoardButton} from "components/ImportBoard";
import {Switch} from "components/Switch/Switch";
import {SearchIcon} from "components/Icon";
Expand All @@ -18,7 +17,6 @@ export const Boards = () => {
const {t} = useTranslation();
const location = useLocation();
const navigate = useNavigate();
const dispatch = useAppDispatch();

// path segments after "/boards", e.g. ["edit-board", "<uuid>", "settings"].
const subPaths = location.pathname.split("/").filter(Boolean).slice(1);
Expand All @@ -36,11 +34,6 @@ export const Boards = () => {
const allowAnonymousBoardCreation = useAppSelector((state) => state.view.allowAnonymousBoardCreation);
const canCreateBoard = !isAnonymous || allowAnonymousBoardCreation;

// init templates
useEffect(() => {
dispatch(getTemplates());
}, [dispatch]);

const renderTitle = () => {
switch (boardView) {
case "templates":
Expand Down
6 changes: 4 additions & 2 deletions src/routes/Boards/Templates/Templates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ export const Templates = () => {

// init templates
useEffect(() => {
dispatch(getTemplates());
}, [dispatch]);
if (showCustomTemplates) {
dispatch(getTemplates());
}
}, [dispatch, showCustomTemplates]);

const toggleFavourite = (templateId: string, favourite: boolean, type: "RECOMMENDED" | "CUSTOM") => {
if (type === "RECOMMENDED") {
Expand Down
Loading