tests : Add unit tests for Alert class #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmazzap
requested changes
Nov 28, 2025
Contributor
gmazzap
left a comment
gmazzap
left a comment
There was a problem hiding this comment.
Thak you for you work.
The code is ok. I would not consider this particular super-helpful as it only tests something that is quite hardcoded in the code.
Also, not sure why of all the Data implemntations, only "Alert" recived the tests.
Finally, the tests could be cleaner using data providers.
However, what stops me from merging is the failed actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive unit tests for the Alert class, covering: