Add PHP 8.5 support #122
Merged
Add PHP 8.5 support #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrico
approved these changes
Nov 28, 2025
gmazzap
approved these changes
Nov 28, 2025
Contributor
|
@Soean It seems WordPress has not yet published the official Docker image for PHP 8.5. So integration test fails for trying to download an image that does not exist. Can you confirm the integration tests pass on PHP 8.5? If so, we can remove the tests for now and merge this. |
Contributor
|
We should also lock Patchwork dependency to the latest 2.2.3, or unit tests fail for "lowest" depndecies installation. |
gmazzap
approved these changes
Nov 28, 2025
This reverts commit 674f654.
Contributor
Author
|
@gmazzap The docker image is released, the tests look good ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119