-
Notifications
You must be signed in to change notification settings - Fork 6
Fix/test playwright #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mishautkin
wants to merge
22
commits into
main
Choose a base branch
from
fix/test-playwright
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/test playwright #223
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
eab074b
Add WORK_DIR input
mishautkin 93915dc
Add GH_TOKEN to PRE_SCRIPT
mishautkin 9ae5c30
Add PLAYWRIGHT_GREP and PLAYWRIGHT_PROJECT inputs
mishautkin 518e6ff
Update documentation
mishautkin 51b8515
Move .env.ci creation to a separate step
mishautkin dd6b433
Add PLAYWRIGHT_GREP_INVERT input for custom commands
mishautkin 2b101e0
Update documentation for `--grep-invert`
mishautkin 4ecd866
Fix quotes in playwright custom commands
mishautkin d7aad04
Lint md fix
mishautkin 9376943
Move GH_TOKEN to PR_SCRIPT step
mishautkin 028f13b
Replace PLAYWRIGHT_ inputs with a single PLAYWRIGHT_CLI_ARGS
mishautkin 9b99dc9
Update documentation for PLAYWRIGHT_CLI_ARGS
mishautkin 14c2607
Lint md fix
mishautkin 6a6d159
Update test-playwright.yml
mishautkin 5e5e67a
Remove PLAYWRIGHT_CLI_ARGS input
mishautkin 6637d73
Merge branch 'fix/test-playwright' of https://github.com/inpsyde/reus…
mishautkin 3b962f5
Rename SCRIPT_NAME to PLAYWRIGHT_SCRIPT
mishautkin f6a50e1
Increase job timeout
mishautkin e293364
Update default node version
mishautkin 334d56a
Update docs
mishautkin 58844e3
Add COMPOSER_AUTH to Playwright workflow PRE_SCRIPT environment variable
Biont 0481294
Add wp-env boot step to Playwright workflow
Biont File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
During the last meeting, we agreed to move all the npm dependencies to the root
package.jsonto avoid this kind of complication, since there is no evidence that your dependencies will cause version clashes. Can you please explain why you are introducing this input? 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've explained this in the first point of "What is the new behavior" section. But maybe I can find a workaround, e.g. by switching the
tests:dir inplaywright.config🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to be hard to pull off without also assuming control of the
playwright.config.js. From my (limited) experience, Playwright is pretty stoic about the way it is configured and bootstraps itself from the config file with extremely limited entrypoints for external configuration/overrides.We could use npm workspaces to isolate Playwright while also satisfying the centralized
node_modules/requirement, but I am not sure if that really reduces the complexity of the setup. It would allow us to install playwright in the root while executing it inWORK_DIR.But this still requires the project to be structured to suit the workflow (instead of configuring the workflow to suit the project within a reasonable framework)
It might be a middleground here though.
Another idea:
Playwright supports pointing to a config file with
--config- is it then also resolving and picking up tests relative to the config file? Then we would only need aPLAYWRIGHT_CONFIGinputUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I remember about this unresolved comment. Moving playwright and all it's dependencies from
tests/qa/toroottakes some time. I need to go through some PRs on Mollie before I can tackle this.In case of several PW projects (like on PayPal with legacy UI), my plan is to manage
testDirinplaywright.configusing path stored in env varPLAYWRIGHT_TEST_DIR='tests/qa/tests'.