feat(build-and-distribute): add NPM_BUILD_SCRIPT input to allow custom build scripts#234
Open
feat(build-and-distribute): add NPM_BUILD_SCRIPT input to allow custom build scripts#234
Conversation
…m build scripts Add optional NPM_BUILD_SCRIPT input so callers can override the default `build` npm script — e.g. to run `build:dev` on feature branches and `build` on stable branches/tags. - Add NPM_BUILD_SCRIPT workflow input (default: empty, falls back to 'build') - Update "Compile assets" step to use the input with || fallback - Document new input and provide conditional usage example in docs
Contributor
Author
|
Quick question, if we go in the Let's say we set There may be a caveat: the cache will need to be handled differently because we now have two build types, dev and prod. If the With the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NPM_BUILD_SCRIPTinput tobuild-and-distributeworkflow (defaults to empty, falls back tobuild)|| 'build'fallbackUsage example
Test plan
npm run buildwhenNPM_BUILD_SCRIPTis not providedNPM_BUILD_SCRIPTis setCloses #207