Skip to content

Bump electron from 24.2.0 to 24.8.5 #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −17
Open

Bump electron from 24.2.0 to 24.8.5 #3191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -219,7 +219,7 @@
"classnames": "2.2.6",
"csv-stringify": "5.5.1",
"cucumber-html-reporter": "5.2.0",
"electron": "24.2.0",
"electron": "24.8.5",
"electron-log-daedalus": "2.2.21",
"electron-store": "8.0.1",
"es6-error": "4.1.1",
28 changes: 12 additions & 16 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -3196,9 +3196,10 @@
"@types/node" "*"
form-data "^3.0.0"

"@types/node@*", "@types/node@14 || 16 || 17":
version "17.0.31"
resolved "https://registry.yarnpkg.com/@types/node/-/node-17.0.31.tgz#a5bb84ecfa27eec5e1c802c6bbf8139bdb163a5d"
"@types/node@*", "@types/node@>=13.7.0", "@types/node@^18.11.18":
version "18.16.7"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.16.7.tgz#86d0ba2541f808cb78d4dc5d3e40242a349d6db8"
integrity sha512-MFg7ua/bRtnA1hYE3pVyWxGd/r7aMqjNOdHvlSsXV3n8iaeGKkOaPzpJh6/ovf4bEXWcojkeMJpTsq3mzXW4IQ==

"@types/node@11.11.6":
version "11.11.6"
@@ -3208,23 +3209,18 @@
version "14.18.16"
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.16.tgz#878f670ba3f00482bf859b6550b6010610fc54b5"

"@types/node@14 || 16 || 17":
version "17.0.35"
resolved "https://registry.yarnpkg.com/@types/node/-/node-17.0.35.tgz#635b7586086d51fb40de0a2ec9d1014a5283ba4a"

"@types/node@14.18.1":
version "14.18.1"
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.1.tgz#459886b51f52aa923dc06b9ea81cb8b1d733e9d3"

"@types/node@>=13.7.0":
version "17.0.35"
resolved "https://registry.yarnpkg.com/@types/node/-/node-17.0.35.tgz#635b7586086d51fb40de0a2ec9d1014a5283ba4a"

"@types/node@^12.7.2":
version "12.20.50"
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.20.50.tgz#14ba5198f1754ffd0472a2f84ab433b45ee0b65e"

"@types/node@^18.11.18":
version "18.16.7"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.16.7.tgz#86d0ba2541f808cb78d4dc5d3e40242a349d6db8"
integrity sha512-MFg7ua/bRtnA1hYE3pVyWxGd/r7aMqjNOdHvlSsXV3n8iaeGKkOaPzpJh6/ovf4bEXWcojkeMJpTsq3mzXW4IQ==

"@types/normalize-package-data@^2.4.0":
version "2.4.1"
resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.1.tgz#d3357479a0fdfdd5907fe67e17e0a85c906e1301"
@@ -7369,10 +7365,10 @@ electron-to-chromium@^1.4.118:
version "1.4.131"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.131.tgz#ca42d22eac0fe545860fbc636a6f4a7190ba70a9"

electron@24.2.0:
version "24.2.0"
resolved "https://registry.yarnpkg.com/electron/-/electron-24.2.0.tgz#54623a909e2e5d53a69d5fd8bf22ab37e61c188b"
integrity sha512-fEYAftYqFhveniWJbEHXjNMWjooFFIuqNj/eEFJkGzycInfBJq/c4E/dew++s6s0YLubxFnjoF2qZiqapLj0gA==
electron@24.8.5:
version "24.8.5"
resolved "https://registry.yarnpkg.com/electron/-/electron-24.8.5.tgz#795e13670f89de927bc4e40fd2a64ff7f9f7c3b6"
integrity sha512-CWSF0CrD1XhxyoXUcCcEoJB8orMTHuOrkj2s87XU11vjgVJHhzhCBh9TVqhMQt7U6TtcGYa5kDIiLRekxJRaRA==
dependencies:
"@electron/get" "^2.0.0"
"@types/node" "^18.11.18"

Unchanged files with check annotations Beta

View file
source/main/cardano/utils.ts
cancelId: 1,
noLink: true,
};
return dialog.showMessageBox(mainWindow, exportWalletsDialogOptions);

Check failure on line 414 in source/main/cardano/utils.ts

GitHub Actions / tests 

Argument of type '{ buttons: any[]; type: string; title: any; message: any; defaultId: number; cancelId: number; noLink: boolean; }' is not assignable to parameter of type 'MessageBoxOptions'.
};
View file
source/main/index.ts
};
const { response } = await dialog.showMessageBox(
mainWindow,
exitSelfnodeDialogOptions

Check failure on line 295 in source/main/index.ts

GitHub Actions / tests 

Argument of type '{ buttons: string[]; type: string; title: string; message: string; defaultId: number; cancelId: number; noLink: boolean; }' is not assignable to parameter of type 'MessageBoxOptions'.
);
if (response === 0) {
View file
source/main/utils/buildAppMenus.ts
};
const { response } = await dialog.showMessageBox(
mainWindow,
blankScreenFixDialogOptions

Check failure on line 101 in source/main/utils/buildAppMenus.ts

GitHub Actions / tests 

Argument of type '{ buttons: any[]; type: string; title: any; message: any; defaultId: number; cancelId: number; noLink: boolean; }' is not assignable to parameter of type 'MessageBoxOptions'.
);
if (response === 0) {