Skip to content

Revert "[LW-12241] Update index.ts to cater for the cleardown of ledger state" #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Revert "[LW-12241] Update index.ts to cater for the cleardown of ledger state" #3279

merged 1 commit into from
Feb 26, 2025
+0 −44

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Feb 26, 2025 •
edited by jira bot
Loading

This reverts commit b54a34e.

The ledger team say it’s unnecessary.

More details in LW-12241.

@michalrus
Revert "[LW-12241] Update index.ts to cater for the cleardown of ledg…
1e55c28 
…er state if not alr… (#3276)"

This reverts commit b54a34e.

The ledger team say it’s unnecessary.
@michalrus michalrus self-assigned this Feb 26, 2025
clkmango
clkmango approved these changes Feb 26, 2025
View reviewed changes
Copy link

@clkmango clkmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we discussed and its a removal of clearLedger and its understood and aproved

hegaleon
hegaleon approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@hegaleon hegaleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this AM and with removal of imports and clearLedger + invocation we are agreed

@michalrus michalrus merged commit 02e2463 into develop Feb 26, 2025
5 checks passed
@michalrus michalrus deleted the chore/LW-12241-revert branch February 26, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegaleon hegaleon hegaleon approved these changes

@szymonmaslowski szymonmaslowski szymonmaslowski approved these changes

@clkmango clkmango clkmango approved these changes

Assignees

@michalrus michalrus

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalrus @hegaleon @szymonmaslowski @clkmango