Enable Docusaurus future flags to prepare for v4#3403
Conversation
Test Results 5 files ± 0 209 suites ±0 54m 51s ⏱️ - 2h 24m 39s Results for commit d643dca. ± Comparison against base commit 86e1c01. This pull request removes 75 tests.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Sadly there's two issues:
- enabling
useCssCascadeLayersjust broke the website design except on the home page (see animation) - Admonitions with a custom title are broken (visible at the bottom of the animation, it now show "::note Note")
For 1. it's a limitation with the redesign (#2597) as it straight copied some docusaurus components, meaning that to update them for useCssCascadeLayers we basically have to redo the design.
Here's what the designer answered to that concern:
When upgrading to docusaurus 4 you may indeed need to stash the changed theme components and manually check what/where to change so that you get the same nav and footer component as right now - it may end up being a simple swap in depending on what components are reworked.
Though with it they appear to be shifting away from their .css file and moving to infima so a revision of the docs site will be required regardless of the theme directory components.
We may look into it, but I think that task will be difficult without a designer.
For 2. the fix is simple, the custom title must be surround by brackets, e.g.:
-:::info Update 2024/10/02
+:::info[Update 2024/10/02]This have to be applied to all admonitions with a custom title (which can be found by tracking :::).
|
thanks @Alenar. I'll take a look and try to fix it. |
f6f8e42 to
379586f
Compare
Content
Pre-submit checklist
N/A - minor change
Comments
My first PR, so let me know if any additional formatting required.
Issue(s)
Related to draft https://github.com/orgs/input-output-hk/projects/26/views/14?pane=issue&itemId=119928726