change: move data epoch offset calculation out of data sources#1123
Open
AmbientTea wants to merge 1 commit intomasterfrom
Open
change: move data epoch offset calculation out of data sources#1123AmbientTea wants to merge 1 commit intomasterfrom
AmbientTea wants to merge 1 commit intomasterfrom
Conversation
ff4ba26 to
e8d2e85
Compare
AmbientTea
commented
Dec 11, 2025
toolkit/committee-selection/authority-selection-inherents/src/ariadne_inherent_data_provider.rs
Outdated
Show resolved
Hide resolved
51c6798 to
8f13775
Compare
kpinter-iohk
approved these changes
Dec 12, 2025
8f13775 to
8b74141
Compare
b06e566 to
64cdbf3
Compare
64cdbf3 to
804a48c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
data_epochfrom theAuthoritySelectionDataSourcetrait. This method was used internally to apply the 2-epoch offset within each data source method, but was also exposed outside becauseAriadneInherentDataProviderneeded it too in its own logic.Instead, the data source now simply serves data for the epoch it receives and it's solely
AriadneInherentDataProvider's responsibility to calculate it.This change is backwards compatible.
Checklist
changelog.mdfor affected crate