Skip to content

change: move data epoch offset calculation out of data sources#1123

Open
AmbientTea wants to merge 1 commit intomasterfrom
data-source-cleanups
Open

change: move data epoch offset calculation out of data sources#1123
AmbientTea wants to merge 1 commit intomasterfrom
data-source-cleanups

Conversation

@AmbientTea
Copy link
Copy Markdown
Contributor

@AmbientTea AmbientTea commented Dec 11, 2025

Description

Removes the data_epoch from the AuthoritySelectionDataSource trait. This method was used internally to apply the 2-epoch offset within each data source method, but was also exposed outside because AriadneInherentDataProvider needed it too in its own logic.

Instead, the data source now simply serves data for the epoch it receives and it's solely AriadneInherentDataProvider's responsibility to calculate it.

This change is backwards compatible.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@AmbientTea AmbientTea marked this pull request as ready for review December 11, 2025 14:36
Copy link
Copy Markdown
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AmbientTea AmbientTea enabled auto-merge (squash) December 15, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants