add local-env with mixed dbsync/dolos data source nodes and diff returned values#1128
Open
kpinter-iohk wants to merge 1 commit intomasterfrom
Open
add local-env with mixed dbsync/dolos data source nodes and diff returned values#1128kpinter-iohk wants to merge 1 commit intomasterfrom
kpinter-iohk wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
dolos-diffthat runs data source queries against both dbsync and dolos, and logs if the result is not identical, then returns the result from dolos.-d 8to local-env to deploy an env with 2 nodes that use db-sync and 3 that use the above dolos/db-sync diff source.McHashDataSource::get_candidatesreturns slightly different results,stake_delegationbeing off. I added a comment in the code where this is happening.Checklist
changelog.mdfor affected crate