task(PM-22100): Add per-query Prometheus metrics for DBSync queries#1150
Draft
task(PM-22100): Add per-query Prometheus metrics for DBSync queries#1150
Conversation
Initial commit for work package PM-22100. Adds granular Prometheus timing histograms for each DBSync query executed during block production and epoch committee rotation. Jira: PM-22100 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Prometheus per-query timing histograms for midnight-node data sources by updating the local
observed_async_trait!macro to record metrics.🎫 Ticket 📐 Engineering
Motivation
DBSync queries to Cardano mainnet are significantly slower than preview (~6s vs ~0.2s). The team needs per-query Prometheus timing histograms to identify which specific queries exceed block production time. Partner-chains data sources already have these metrics, but midnight-node data sources (cNight observation, federated authority, candidates) use a local macro that only logs — no Prometheus timing.
Changes
Update: After investigation, no changes are needed in partner-chains. The
McFollowerMetricsaccessor methods are alreadypuband theobserved_async_trait!macro is already#[macro_export]ed. All changes go in midnight-node — see the midnight-node PR.This PR may be closed in favor of the midnight-node PR.
📌 Submission Checklist
🔱 Fork Strategy
🗹 TODO before merging