feat: add automatic-generate-keys command to partner-chains CLI#924
Open
feat: add automatic-generate-keys command to partner-chains CLI#924
Conversation
ladamesny
changed the title
Contributor
Author
|
Replaces this PR: #867 |
ladamesny
force-pushed
the
feat/automatic-generate-keys-final
branch
2 times, most recently
from
8658932 to
2b654ab
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys-final
branch
from
2b654ab to
1acab37
Compare
…tion UX - Introduced command to partner-chains-cli: - Generates and saves session keys by connecting to a running node via RPC () - Decodes session keys using the runtime API, supports modern and legacy formats, and saves to keystore and JSON - Provides fallback and error handling for various runtime formats - Integrated the new command into the CLI as an alternative to for all roles (Governance Authority, Registered Validator, Permissioned Validator) - Updated CLI help message and workflow documentation to clearly present both key generation methods and when to use each - Added comprehensive test suite for SCALE decoding and key handling logic - Updated changelog with details of the new feature and related improvements - Updated Cargo.toml and workspace dependencies for , (with serde), and related requirements
…erate keys command
ladamesny
force-pushed
the
feat/automatic-generate-keys-final
branch
from
ea6e0dc to
b518140
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys-final
branch
from
b518140 to
1fccb55
Compare
AmbientTea
reviewed
Jan 21, 2026
Contributor
AmbientTea
left a comment
AmbientTea
left a comment
There was a problem hiding this comment.
This PR is super old at this point. Is it still relevant? I'm assigned as a reviewer, but I have no idea if this is needed at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overview
Added a new automatic-generate-keys command that automatically generates session keys by connecting to a running Partner Chain node via RPC, eliminating the need for manual key generation and parsing. Jira Ticket ETCM-11971
Implementation Details
Command Structure:
Uses a clean two-RPC-call approach:
Key Benefits:
✅ No assumptions - Node provides actual key types (e.g., "gran", "imon", "aura")
✅ Runtime-agnostic - Works with any SessionKeys configuration
✅ No manual parsing - Node handles all SCALE decoding internally
✅ Always accurate - Impossible to get key order wrong
Checklist
changelog.mdfor affected crate