Skip to content

Add CIP for giving a fee change to a reward address - #36

Open
polinavino wants to merge 4 commits into
mainfrom
polina/fee-cip
Open

Add CIP for giving a fee change to a reward address#36
polinavino wants to merge 4 commits into
mainfrom
polina/fee-cip

Conversation

@polinavino

Copy link
Copy Markdown
Contributor

No description provided.

a transaction may end up being processed
at a lower effective fee than originally stated. For example, this may happen because network demand
at the time of inclusion was lower than anticipated, or because the transaction's
specified expected delay period was exceeded before it was entered into a block.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a lot of context (of tiered pricing I mean) loaded in this. I'm not necessarily objecting to that, but it could be a source of questions.

Comment thread docs/CIP-fee-change/CIP-fee-change.md Outdated
No additional signing requirements are imposed, as it is not mandatory for a
user to output fee change into an address they own.

(1) We changes the *produced* calculation are :

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "The changes to the..." I'm guessing?

and does not need to be reflected in a transaction output. Making the change
address optional allows for backwards compatibility.

### Ledger rule changes

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have mentioned it, but I can't see where we state what happens if no fee change address is supplied.

No changes to `TxInfo` are required. The reason for this is that all Plutus scripts
should be blind to the fee change provided. This value is not fixed at the time of
transaction construction and therefore cannot be used to predict the outcome of
script validation at the time of construction. Note here that this change may

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it'd make sense to draw more attention to this point. Maybe a separate paragraph and "Note: ", something like that?

Comment thread docs/CIP-fee-change/CIP-fee-change.md Outdated

### Acceptance criteria

- [ ] The tiered-pricing CIP (or equivalent) is published and specifies a concrete

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't necessarily need to declare these dependencies here, do we? A node could choose to refund an arbitrary portion of any fee for an internal reason, right? We don't need to couple this to the method of calculating the refund amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants