Modernize for Apple Silicon (native arm64) and current Xcode/macOS#49
Open
TackerCochrane wants to merge 1 commit into
Open
Modernize for Apple Silicon (native arm64) and current Xcode/macOS#49TackerCochrane wants to merge 1 commit into
TackerCochrane wants to merge 1 commit into
Conversation
Brings the project up to date so it builds and runs as a native universal (arm64 + x86_64) app on current macOS and Xcode, replacing the Intel-only build that macOS now warns about. Dependencies - Migrate Carthage -> Swift Package Manager (resolves automatically on open). - Update SwiftyJSON 3 -> 5 and Sparkle 1 -> 2 (SUUpdater -> SPUStandardUpdaterController). - Remove Fabric/Crashlytics (SDK discontinued in 2020). - Remove IGListKit, which was listed as a dependency but never imported. Build settings - Swift 3 -> Swift 5 language mode. - Deployment target 10.11 -> 11.0. - Signing left as Automatic with no hard-coded team. Source migration (Swift 3 -> Swift 5 / current SDK) - AppKit renames across ~13 files (NSImage.Name, NSControl.StateValue, NSTouchBarItem.Identifier, autoresizing masks, NSWorkspace.shared, etc.). - Restore @objc on members called from Objective-C / used as selectors. Runtime crash fixes on modern macOS - PMEventTap: guard against a NULL CGEventTapCreate result (returns NULL without Input Monitoring permission), which previously crashed on launch. - Touch Bar: the private SPI was renamed by Apple in 10.14 (presentSystemModalFunctionBar: -> presentSystemModalTouchBar:); update the declaration and call sites so Touch Bar works again instead of crashing on launch. Small additions - Right-click (or control-click) the menu-bar icon for a Quit menu item. - Use the gearshape SF Symbol for the in-popover options button. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent macOS notifications appeared warning that the Intel build "will not open in a future release," so I took a pass at bringing the project up to date. It now builds and runs as a native universal (arm64 + x86_64) app on current Xcode/macOS. Sharing it back in case it's useful; totally understand if you'd rather take a different approach.
Verified working: app launches, Overcast loads and plays, menu bar + popover, media keys, and the Touch Bar UI all function. Every JS selector the app injects still matches Overcast's current page, so the scraping is intact.
I took the liberty of adding one small feature that I have always wished for:
Below is some nerd stuff.
List of dependencies
SUUpdater→SPUStandardUpdaterController)Showing my work
Some behind-the-scenes fixes
@objcwhere neededCGEventTapCreate(returns NULL without Input Monitoring permission) instead of crashingpresentSystemModalFunctionBar:→presentSystemModalTouchBar:)Notes on updates