Skip to content

Add args as an attribute to output of ard_strata() and ard_pairwise()#545

Open
alanahjonas95 wants to merge 5 commits intoinsightsengineering:mainfrom
alanahjonas95:issue484
Open

Add args as an attribute to output of ard_strata() and ard_pairwise()#545
alanahjonas95 wants to merge 5 commits intoinsightsengineering:mainfrom
alanahjonas95:issue484

Conversation

@alanahjonas95
Copy link
Contributor

@alanahjonas95 alanahjonas95 commented Feb 27, 2026

What changes are proposed in this pull request?

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'

resolves #483

I've updated two fuctions wanted to confirm these are ok before doing others


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Optional Reverse Dependency Checks:

Install checked with pak::pak("Genentech/checked") or pak::pak("checked")

# Check dev versions of `cardx`, `gtsummary`, and `tfrmt` which are in the `ddsjoberg` R Universe
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2L, repos = c('https://ddsjoberg.r-universe.dev', 'https://cloud.r-project.org'))"

# Check CRAN reverse dependencies but run tests skipped on CRAN
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

# Check CRAN reverse dependencies in a CRAN-like environment
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = FALSE), checked.check_build_args = '--as-cran'); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

@alanahjonas95 alanahjonas95 changed the title Merged Add args as an attribute to output of ard_strata() and ard_pairwise() Add args as an attribute to output of ard_strata() and ard_pairwise() Feb 27, 2026
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this looks good! Thanks @alanahjonas95

@ddsjoberg to you

@ddsjoberg ddsjoberg requested a review from bzkrouse March 3, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should other functions pass down arguments via the args attribute?

2 participants