Draft
Conversation
Co-authored-by: insoln <11380274+insoln@users.noreply.github.com>
- Add bounds check for token prefix logging to prevent panic - Use url.Values for proper query parameter escaping - Add HTML escaping for redirect URL - Fix CSS border-radius syntax (50% instead of 50%%) - Add explanatory comment for session.Id = "" Co-authored-by: insoln <11380274+insoln@users.noreply.github.com>
- Add Desktop Application Support section to ARCHITECTURE.md - Document desktop token flow and implementation details - Update USER_GUIDE.md with desktop app verification steps - Add desktop app compatibility note to known limitations - Update README.md to list desktop app support in features Co-authored-by: insoln <11380274+insoln@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect login through desktop application
Add desktop application authentication flow
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop app login fails because the plugin lacks token-based authentication flow required by Mattermost desktop clients. After OIDC callback, desktop apps cannot complete session creation via cookie-based flow.
Implementation
Implemented desktop token exchange flow from Mattermost Server v10.11:
Authentication Flow
/loginacceptsdesktop_tokenquery parameter, preserves through OAuth state/callbackdetects desktop_token, generates server token (3-min TTL in KV store)/login/desktoprenders HTML redirect tomattermost://callbackURL scheme/login/desktop_tokenAPI exchanges server token for sessionState Management
authSessionstruct withDesktopToken,RedirectTo,IsMobilefieldsSecurity
url.ValuesCompatibility
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.