Do not error when router list is empty #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmazzini
reviewed
Sep 16, 2025
pmazzini
reviewed
Sep 16, 2025
Signed-off-by: Ralph Schmieder <[email protected]>
Signed-off-by: Ralph Schmieder <[email protected]>
pmazzini
reviewed
Sep 17, 2025
pmazzini
approved these changes
Sep 18, 2025
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #561
According to RFC 2131/2132 "All other [options] MAY" be included in a DHCPOFFER. Thus the gateway is not mandatory and in fact I can configure a DHCP server which "just" hands out an IP address, no problem. However, the client returns no options at all and thus fails the request.
In addition, due to the fact that several tests look for an error to occur pass because the error returned by not having a router defined masks the actual to-be-tested behavior. So I commented them out for the time being. They either need to be modified to test the actual desired error behavior or they should be removed. I did add additional comments on top of each test.