Skip to content

FIx for Head Ident to be fetched from Attributes on AttributedString#71

Open
darko55s wants to merge 1 commit into
instacart:masterfrom
darko55s:bug/head_ident_fix
Open

FIx for Head Ident to be fetched from Attributes on AttributedString#71
darko55s wants to merge 1 commit into
instacart:masterfrom
darko55s:bug/head_ident_fix

Conversation

@darko55s
Copy link
Copy Markdown

Fixes #67

Copy link
Copy Markdown
Contributor

@ngoleo ngoleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @darko55s! Could you add a snapshot test for this scenario so we can prevent this from breaking in the future?

@darko55s
Copy link
Copy Markdown
Author

darko55s commented Mar 3, 2021

@ngocholo Yeah ill do that asap.

@timcmiller
Copy link
Copy Markdown

@darko55s @ngocholo I've been using this locally and noticed if I had a headIndent set the link(at point:) wouldn't account for the offset.

You need to change this line in Link.swift to

lineOrigin.x += penOffset

@frndev
Copy link
Copy Markdown

frndev commented Dec 14, 2021

Any news on this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attributed string attributes not preserved

4 participants