Changed from AWS basic authentication to DefaultAWSCredentialsProvide…#4
Changed from AWS basic authentication to DefaultAWSCredentialsProvide…#4shreepadangg wants to merge 1 commit intoinstaclustr:masterfrom
Conversation
tharinduamila-insta
requested review from
michael-carter-instaclustr and
tharinduamila-insta
michael-carter-instaclustr
left a comment
michael-carter-instaclustr
left a comment
There was a problem hiding this comment.
Thanks very much for your interest in this project, and for your pull request. Unfortunately, we must retain the option for credentials to be explicitly specified, as this gives us the flexibility to allow people to submit S3 connectors to their own buckets in the situation where they aren't in direct control of the Kafka Connect cluster itself. While having the DefaultAWSCredentialProvider as a fallback is a good idea - it cannot be the only way to provide credentials. Perhaps you could alter this to use the default provider chain if the explicit config options are not there?
| .java-version | ||
| *.iml | ||
| .DS_Store | ||
| s3/.DS_Store |
There was a problem hiding this comment.
gitignore is smart enough to know that if you say you don't want .DS_Store, that you don't want it anywhere, so I don't think you need the last three lines here
2 participants
Changed from AWS basic authentication to DefaultAWSCredentialsProviderChain