Skip to content

fix: perf damage in data processing by jnp#42

Merged
chrbrunk merged 1 commit into
instadeepai:developfrom
bhcao:mlip_bugfix
Apr 2, 2026
Merged

fix: perf damage in data processing by jnp#42
chrbrunk merged 1 commit into
instadeepai:developfrom
bhcao:mlip_bugfix

Conversation

@bhcao

@bhcao bhcao commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

See #40 for details.

@CLAassistant

CLAassistant commented Mar 27, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@chrbrunk

chrbrunk commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Hey @bhcao, thanks a lot for this! Looks good to me.

Before, I approve, let me just try to figure out what we can do about the permission issue in the CI.

Also, one small request: could you change the target to develop on mlip. Then we first merge there and then we can on our side update the CHANGELOG and version, before we trigger a new release with the merge to main. Thanks a lot!

@bhcao bhcao changed the base branch from main to develop April 2, 2026 13:23
@bhcao

bhcao commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

The target has been changed to develop.

@chrbrunk

chrbrunk commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Thanks! I think I'll just merge this now as the tests are passing, and the CI permission problem can be solved later on main for future PRs.

I cannot promise that we'll get this merged through to main still today, but that should happen within the next few days at latest.

@chrbrunk chrbrunk merged commit 8c2a5ee into instadeepai:develop Apr 2, 2026
1 of 2 checks passed
@bhcao bhcao deleted the mlip_bugfix branch April 3, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants