fix: perf damage in data processing by jnp#42
Merged
Conversation
Collaborator
|
Hey @bhcao, thanks a lot for this! Looks good to me. Before, I approve, let me just try to figure out what we can do about the permission issue in the CI. Also, one small request: could you change the target to |
Contributor
Author
|
The target has been changed to |
Collaborator
|
Thanks! I think I'll just merge this now as the tests are passing, and the CI permission problem can be solved later on I cannot promise that we'll get this merged through to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #40 for details.