Skip to content

Commit

Permalink
chore(helm): add MinIO extraction TODOS
Browse files Browse the repository at this point in the history
  • Loading branch information
jvallesm committed Feb 17, 2025
1 parent b666cd4 commit a4de35b
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions charts/core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1565,6 +1565,8 @@ milvus:
enabled: true
# https://github.com/zilliztech/milvus-helm/blob/adc5c36dbb417fb259c81535b9b623861fe3f14f/charts/milvus/values.yaml#L485C9-L485C85
# ref: https://github.com/zilliztech/milvus-helm/blob/master/charts/minio/README.md
# TODO: MinIO is used by services like pipeline or artifact, not only Milvus.
# Therefore, it shouldn't be defined as a Milvus dependency (INS-7341).
minio:
mode: distributed
nodeSelector: {}
Expand All @@ -1587,6 +1589,9 @@ milvus:
failureThreshold: 5
environment:
MINIO_AUDIT_WEBHOOK_ENABLE_ARTIFACT: "on"
# TODO: If fullnameOverride is set, artifact's host might change. This
# should be set through templates, which could be done along with the
# MinIO extraction from Milvus (INS-7341).
MINIO_AUDIT_WEBHOOK_ENDPOINT_ARTIFACT: "http://core-artifact-backend:3082/v1alpha/minio-audit"
etcd:
nodeSelector: {}
Expand Down

0 comments on commit a4de35b

Please sign in to comment.