Skip to content

Fix dup mutating original store #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Fix dup mutating original store #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/attributed_string/klass.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ def initialize(string = "", **attrs)
def dup
super.tap do |copy|
new_store = @store.map do |entry|
entry[:range] = entry[:range].dup
entry.dup
entry_dup = entry.dup
entry_dup[:range] = entry_dup[:range].dup
entry_dup
end
copy.instance_variable_set(:@store, new_store)
end
Expand Down
8 changes: 8 additions & 0 deletions test/initializers_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,12 @@ def test_dup
end
end

def test_dup_does_not_modify_original_store
@attr_string.add_attrs(0..4, bold: true)
original_range_id = @attr_string.instance_variable_get(:@store).first[:range].object_id
@attr_string.dup
after_range_id = @attr_string.instance_variable_get(:@store).first[:range].object_id
assert_equal original_range_id, after_range_id
end

end