Skip to content
This repository was archived by the owner on Apr 30, 2026. It is now read-only.

Add AWS region fallback to functional-gpu workflow (backport #668)#671

Merged
booxter merged 1 commit into
release-v0.8from
mergify/bp/release-v0.8/pr-668
Jun 10, 2025
Merged

Add AWS region fallback to functional-gpu workflow (backport #668)#671
booxter merged 1 commit into
release-v0.8from
mergify/bp/release-v0.8/pr-668

Conversation

@mergify

@mergify mergify Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

We're getting out of capacity issues with these smaller instances as well, so add the region fallback logic from our larger e2e jobs to this workflow.


This is an automatic backport of pull request #668 done by Mergify.

@mergify mergify Bot added the conflicts label Jun 10, 2025
@mergify

mergify Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 8ee175e has failed:

On branch mergify/bp/release-v0.8/pr-668
Your branch is up to date with 'origin/release-v0.8'.

You are currently cherry-picking commit 8ee175e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/functional-gpu-nvidia-t4-x1.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added CI/CD Affects CI/CD configuration release-branch labels Jun 10, 2025
@mergify mergify Bot added the one-approval label Jun 10, 2025
We're getting out of capacity issues with these smaller instances as
well, so add the region fallback logic from our larger e2e jobs to
this workflow.

Signed-off-by: Ben Browning <bbrownin@redhat.com>
(cherry picked from commit 8ee175e)

# Conflicts:
#	.github/workflows/functional-gpu-nvidia-t4-x1.yml
@bbrowning bbrowning force-pushed the mergify/bp/release-v0.8/pr-668 branch from 288af0f to f1692aa Compare June 10, 2025 20:25
@bbrowning

Copy link
Copy Markdown
Contributor

I fixed the failed cherry-pick here as well as ensured the fix from #669 made its way into this backport as well.

@booxter booxter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes the job.

@mergify mergify Bot removed the one-approval label Jun 10, 2025
@booxter

booxter commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Since it's a pull_request_target job, it should first pass https://github.com/instructlab/sdg/actions/runs/15570480126 to confirm it works, the automatic CI triggered won't validate the new workflow.

@booxter booxter added hold In-progress PR. Tag should be removed before merge. and removed hold In-progress PR. Tag should be removed before merge. labels Jun 10, 2025
@booxter booxter merged commit 7381ca5 into release-v0.8 Jun 10, 2025
12 checks passed
@bbrowning bbrowning deleted the mergify/bp/release-v0.8/pr-668 branch June 10, 2025 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI/CD Affects CI/CD configuration conflicts release-branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants