This repository was archived by the owner on Apr 30, 2026. It is now read-only.
Add AWS region fallback to functional-gpu workflow (backport #668)#671
Merged
Conversation
Contributor
Author
|
Cherry-pick of 8ee175e has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
courtneypacheco
approved these changes
Jun 10, 2025
We're getting out of capacity issues with these smaller instances as well, so add the region fallback logic from our larger e2e jobs to this workflow. Signed-off-by: Ben Browning <bbrownin@redhat.com> (cherry picked from commit 8ee175e) # Conflicts: # .github/workflows/functional-gpu-nvidia-t4-x1.yml
288af0f to
f1692aa
Compare
Contributor
|
I fixed the failed cherry-pick here as well as ensured the fix from #669 made its way into this backport as well. |
booxter
approved these changes
Jun 10, 2025
booxter
left a comment
Contributor
There was a problem hiding this comment.
Assuming it passes the job.
Contributor
|
Since it's a pull_request_target job, it should first pass https://github.com/instructlab/sdg/actions/runs/15570480126 to confirm it works, the automatic CI triggered won't validate the new workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're getting out of capacity issues with these smaller instances as well, so add the region fallback logic from our larger e2e jobs to this workflow.
This is an automatic backport of pull request #668 done by Mergify.