Skip to content

[MBL-19845][All] Fix inbox attachment upload UI stuck on screen rotation#3606

Merged
kristofnemere merged 2 commits intomasterfrom
MBL-19845-fix-inbox-attachment-rotation
Mar 31, 2026
Merged

[MBL-19845][All] Fix inbox attachment upload UI stuck on screen rotation#3606
kristofnemere merged 2 commits intomasterfrom
MBL-19845-fix-inbox-attachment-rotation

Conversation

@kristofnemere
Copy link
Copy Markdown
Contributor

@kristofnemere kristofnemere commented Mar 25, 2026

Test plan:

  1. Open any of the three apps (Student, Teacher, Parent)
  2. Navigate to Inbox and start composing a new message
  3. Tap the attachment picker and select a file to upload
  4. While the upload is in progress, rotate the device
  5. Verify the upload completes and the attachment UI updates correctly (no longer stuck)

refs: MBL-19845
affects: Student, Teacher, Parent
release note: Fixed an issue where attaching a file in Inbox would freeze the upload UI after rotating the device.

  • Follow-up e2e test ticket created or not needed
  • Tested in dark mode
  • Tested in light mode
  • Test in landscape mode and/or tablet
  • A11y checked
  • Approve from product

kristofnemere and others added 2 commits March 25, 2026 15:27
Move WorkManager observation from viewLifecycleOwner into viewModelScope
using getWorkInfoByIdFlow so the upload state continues to be tracked
after Fragment view is destroyed and recreated on rotation.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

🧪 Unit Test Results

✅ 📱 Parent App

  • Tests: 315 total, 0 failed, 0 skipped
  • Duration: 33.161s
  • Success Rate: 100%

✅ 📱 Student App

  • Tests: 1252 total, 0 failed, 0 skipped
  • Duration: 0.000s
  • Success Rate: 100%

✅ 📱 Teacher App

  • Tests: 373 total, 0 failed, 0 skipped
  • Duration: 31.981s
  • Success Rate: 100%

✅ 🌅 Horizon

  • Tests: 790 total, 0 failed, 0 skipped
  • Duration: 39.043s
  • Success Rate: 100%

✅ 📦 Submodules

  • Tests: 3344 total, 0 failed, 0 skipped
  • Duration: 55.296s
  • Success Rate: 100%

📊 Summary

  • Total Tests: 6074
  • Failed: 0
  • Skipped: 0
  • Status: ✅ All tests passed!

Last updated: Wed, 25 Mar 2026 14:48:32 GMT

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

📊 Code Coverage Report

✅ Student

  • PR Coverage: 42.53%
  • Master Coverage: 42.53%
  • Delta: +0.00%

✅ Teacher

  • PR Coverage: 25.38%
  • Master Coverage: 25.38%
  • Delta: +0.00%

✅ Pandautils

  • PR Coverage: 23.67%
  • Master Coverage: 23.66%
  • Delta: +0.01%

📈 Overall Average

  • PR Coverage: 30.53%
  • Master Coverage: 30.52%
  • Delta: +0.00%

@github-actions
Copy link
Copy Markdown
Contributor

Parent Install Page

@github-actions
Copy link
Copy Markdown
Contributor

Teacher Install Page

@github-actions
Copy link
Copy Markdown
Contributor

Student Install Page

Copy link
Copy Markdown
Contributor

@kdeakinstructure kdeakinstructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 👍

@kristofnemere kristofnemere merged commit 578f812 into master Mar 31, 2026
28 of 29 checks passed
@kristofnemere kristofnemere deleted the MBL-19845-fix-inbox-attachment-rotation branch March 31, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants