Skip to content

[MBL-16950][Student][Teacher] Implement E2E tests for Rubrics #3619

Merged
adamNagy56 merged 5 commits intomasterfrom
MBL-16950-Implement-E2E-test-for-Rubrics
Apr 9, 2026
Merged

[MBL-16950][Student][Teacher] Implement E2E tests for Rubrics #3619
adamNagy56 merged 5 commits intomasterfrom
MBL-16950-Implement-E2E-test-for-Rubrics

Conversation

@adamNagy56
Copy link
Copy Markdown
Contributor

@adamNagy56 adamNagy56 commented Apr 2, 2026

Summary

Implement E2E tests for Rubrics and update related API models.

refs: MBL-16950
affects: Student, Teacher
release note:

Checklist

  • Run E2E test suite

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR adds solid end-to-end rubric testing infrastructure — new RubricsApi seeding support, RubricApiModel / RubricCriterionResponseModel response models, gradeSubmissionWithRubric() in SubmissionsApi, and two new E2E test suites (student and teacher). The production change is minimal and targeted: adding a testTag to the RubricNote column so tests can scope rubric note interactions per-criterion. The rename from assertSubmissionAndRubricLabel()assertSubmissionAndFeedbackLabel() is consistently applied across all call sites.

Issues found

  • Stale log messagesapps/student/.../AssignmentsE2ETest.kt (lines 545, 560, 1115, 1127) and apps/student/.../offline/OfflineAssignmentsE2ETest.kt (line 245) still reference 'Submission & Rubric' in their Log.d messages even though the assertion was updated to assertSubmissionAndFeedbackLabel(). (Inline comments added.)

  • Duplicate seedRubricWithAssignment() — The function is copy-pasted identically into both StudentTestExtensions.kt and TeacherTestExtensions.kt. A single home in the shared :espresso automation module would prevent the two copies from drifting. (Inline comment added.)

  • assertRubricNoteDisplayedWithEditButton() not scoped to a criterion — Unlike every other note-related helper in SpeedGraderGradePage, this assertion does not scope the edit-button lookup to a specific criterionId ancestor. With multiple criteria it could silently pass against the wrong criterion. (Inline comment added with suggested fix.)

  • Implicit expandSlidingPanel() precondition + low visibility thresholdassertRubricCriterionDisplayed() in SubmissionDetailsPage now silently requires callers to have previously called expandSlidingPanel(), and the visibility threshold was dropped to 3 %. Both are worth documenting / revisiting. (Inline comment added.)

Minor notes (no inline comment)

  • RubricE2ETest.kt and StudentTestExtensions.kt are both missing a trailing newline (\ No newline at end of file in the diff). Minor, but can produce noisy diffs and confuse some tooling.
  • parent/AssignmentDetailsE2ETest.kt line 133 also has a stale log message referencing 'Submission & Rubric' that wasn't caught by the search above — worth a quick scan of the parent app test log messages too.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

🧪 Unit Test Results

✅ 📱 Student App

  • Tests: 1252 total, 0 failed, 0 skipped
  • Duration: 0.000s
  • Success Rate: 100%

✅ 📱 Teacher App

  • Tests: 373 total, 0 failed, 0 skipped
  • Duration: 33.552s
  • Success Rate: 100%

✅ 🌅 Horizon

  • Tests: 790 total, 0 failed, 0 skipped
  • Duration: 34.979s
  • Success Rate: 100%

✅ 📦 Submodules

  • Tests: 3349 total, 0 failed, 0 skipped
  • Duration: 60.472s
  • Success Rate: 100%

📊 Summary

  • Total Tests: 5764
  • Failed: 0
  • Skipped: 0
  • Status: ✅ All tests passed!

Last updated: Wed, 08 Apr 2026 10:18:41 GMT

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

📊 Code Coverage Report

✅ Student

  • PR Coverage: 42.65%
  • Master Coverage: 42.65%
  • Delta: +0.00%

✅ Teacher

  • PR Coverage: 25.37%
  • Master Coverage: 25.37%
  • Delta: +0.00%

⚠️ Pandautils

  • PR Coverage: 23.69%
  • Master Coverage: 23.69%
  • Delta: -0.00%

📈 Overall Average

  • PR Coverage: 30.57%
  • Master Coverage: 30.57%
  • Delta: -0.00%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Teacher Install Page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Student Install Page

@kdeakinstructure kdeakinstructure self-requested a review April 2, 2026 12:15
refs: MBL-16950
affects: Student, Teacher
release note:
@adamNagy56 adamNagy56 merged commit 51ea2d5 into master Apr 9, 2026
84 of 93 checks passed
@adamNagy56 adamNagy56 deleted the MBL-16950-Implement-E2E-test-for-Rubrics branch April 9, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants