[MBL-16950][Student][Teacher] Implement E2E tests for Rubrics #3619
[MBL-16950][Student][Teacher] Implement E2E tests for Rubrics #3619adamNagy56 merged 5 commits intomasterfrom
Conversation
refs: MBL-16950 affects: Student, Teacher release note:
There was a problem hiding this comment.
Review Summary
This PR adds solid end-to-end rubric testing infrastructure — new RubricsApi seeding support, RubricApiModel / RubricCriterionResponseModel response models, gradeSubmissionWithRubric() in SubmissionsApi, and two new E2E test suites (student and teacher). The production change is minimal and targeted: adding a testTag to the RubricNote column so tests can scope rubric note interactions per-criterion. The rename from assertSubmissionAndRubricLabel() → assertSubmissionAndFeedbackLabel() is consistently applied across all call sites.
Issues found
-
Stale log messages —
apps/student/.../AssignmentsE2ETest.kt(lines 545, 560, 1115, 1127) andapps/student/.../offline/OfflineAssignmentsE2ETest.kt(line 245) still reference'Submission & Rubric'in theirLog.dmessages even though the assertion was updated toassertSubmissionAndFeedbackLabel(). (Inline comments added.) -
Duplicate
seedRubricWithAssignment()— The function is copy-pasted identically into bothStudentTestExtensions.ktandTeacherTestExtensions.kt. A single home in the shared:espressoautomation module would prevent the two copies from drifting. (Inline comment added.) -
assertRubricNoteDisplayedWithEditButton()not scoped to a criterion — Unlike every other note-related helper inSpeedGraderGradePage, this assertion does not scope the edit-button lookup to a specificcriterionIdancestor. With multiple criteria it could silently pass against the wrong criterion. (Inline comment added with suggested fix.) -
Implicit
expandSlidingPanel()precondition + low visibility threshold —assertRubricCriterionDisplayed()inSubmissionDetailsPagenow silently requires callers to have previously calledexpandSlidingPanel(), and the visibility threshold was dropped to 3 %. Both are worth documenting / revisiting. (Inline comment added.)
Minor notes (no inline comment)
RubricE2ETest.ktandStudentTestExtensions.ktare both missing a trailing newline (\ No newline at end of filein the diff). Minor, but can produce noisy diffs and confuse some tooling.parent/AssignmentDetailsE2ETest.ktline 133 also has a stale log message referencing'Submission & Rubric'that wasn't caught by the search above — worth a quick scan of the parent app test log messages too.
🧪 Unit Test Results✅ 📱 Student App
✅ 📱 Teacher App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Wed, 08 Apr 2026 10:18:41 GMT |
📊 Code Coverage Report✅ Student
✅ Teacher
|
refs: MBL-16950 affects: Student, Teacher release note:
refs: MBL-16950 affects: Student, Teacher release note:
Summary
Implement E2E tests for Rubrics and update related API models.
refs: MBL-16950
affects: Student, Teacher
release note:
Checklist