Merge Teacher release#3624
Conversation
refs: MBL-19863 affects: Student, Teacher, Parent release note: - (cherry picked from commit fae7557)
* Fix New Login UI changes in E2E tests. refs: MBL-19864 affects: Student, Teacher, Parent release note: - * Fix LoginSignInPage UI element selectors + Stub a test (needs further investigation). * Add util function for react input notifying. * Stabilize Login tests by waiting for email and password field to be displayed before making interaction with them. * Stub Student DashboardE2ETest (cherry picked from commit 92883f8)
Removed @singleton annotation because it caused issues (cherry picked from commit b777ed4)
# Conflicts: # apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/compose/LoginE2ETest.kt
🧪 Unit Test Results📊 Summary
Last updated: Tue, 07 Apr 2026 07:49:53 GMT |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR bumps the Teacher app to version 2.6.0 (code 91) and excludes two login E2E tests from the release pipeline via @ReleaseExclude.
Looks good overall. The version bump is clean and the use of @ReleaseExclude to gate flaky/problematic tests out of release runs is the right pattern (confirmed by the flank_e2e.yml notAnnotation filter).
Issues
- Missing
excludeReasonon both@ReleaseExcludeannotations (LoginE2ETest.ktlines 53 and 148) — The annotation declares anexcludeReason: Stringparameter and its own KDoc explicitly says the reason should be "explained in the parameter". Leaving it blank makes it impossible for future maintainers to know why these tests were excluded or when/whether to re-enable them. See inline comments for suggested fix.
|
|
||
| @E2E | ||
| @Test | ||
| @ReleaseExclude |
There was a problem hiding this comment.
The @ReleaseExclude annotation supports an excludeReason parameter specifically to document why the test is excluded from the release process. The annotation's own KDoc says the reason should be "explained in the parameter". Without it, future maintainers won't know whether this exclusion is intentional, temporary, or forgotten.
| @ReleaseExclude | |
| @ReleaseExclude(excludeReason = "<describe the reason, e.g. flaky due to X>") |
|
|
||
| @E2E | ||
| @Test | ||
| @ReleaseExclude |
There was a problem hiding this comment.
Same as above — please include an excludeReason so the intent is clear.
| @ReleaseExclude | |
| @ReleaseExclude(excludeReason = "<describe the reason, e.g. flaky due to X>") |
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
3 participants
No description provided.