Merge release student#3626
Merged
tamaskozmer merged 11 commits intomasterfrom Apr 7, 2026
Merged
Conversation
refs: MBL-19863 affects: Student, Teacher, Parent release note: - (cherry picked from commit fae7557)
This reverts commit c2a0a6f.
* Fix New Login UI changes in E2E tests. refs: MBL-19864 affects: Student, Teacher, Parent release note: - * Fix LoginSignInPage UI element selectors + Stub a test (needs further investigation). * Add util function for react input notifying. * Stabilize Login tests by waiting for email and password field to be displayed before making interaction with them. * Stub Student DashboardE2ETest (cherry picked from commit 92883f8)
Removed @singleton annotation because it caused issues (cherry picked from commit b777ed4)
# Conflicts: # apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/compose/LoginE2ETest.kt
Contributor
🧪 Unit Test Results📊 Summary
Last updated: Tue, 07 Apr 2026 08:51:07 GMT |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This is a standard release bump for Canvas Student 8.7.0 (versionCode 290). The changes are minimal and straightforward.
Looks good:
- Version code increment is correct (289 → 290)
- Version name follows semver conventions for a minor release (8.6.1 → 8.7.0)
Questions / Items to verify:
-
.github/workflows/release-student.ymlline 19:include-e2e-offlinechanged fromtruetofalse— please confirm this is intentional. If offline E2E tests are being temporarily skipped due to flakiness or breakage, a follow-up ticket to re-enable them would help ensure offline functionality coverage isn't lost long-term.
kristofnemere
approved these changes
Apr 7, 2026
Contributor
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.