Merge back student release#3638
Merged
tamaskozmer merged 3 commits intomasterfrom Apr 13, 2026
Merged
Conversation
refs: MBL-19940 affects: Student release note: Fixed an issue where students were logged out when entering split-screen or multi-window mode on Android tablets. (cherry picked from commit fc199e6)
Contributor
🧪 Unit Test Results📊 Summary
Last updated: Mon, 13 Apr 2026 07:42:39 GMT |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This is a small, targeted patch release with two changes.
What's changed:
- Student app version bump:
8.7.0(code 290) →8.7.1(code 291) FeatureFlagProvider.fetchEnvironmentFeatureFlags(): removedshouldIgnoreToken = truefrom theRestParamspassed to thefeatures/environmentAPI call
Assessment:
The bug fix is correct and well-scoped. The GET /api/v1/features/environment endpoint is user-context-sensitive and needs authentication — calling it without the Bearer token would cause the server to either return a 401 or respond with data for an anonymous context, silently producing wrong feature flag state. Removing shouldIgnoreToken = true restores the expected authenticated behavior.
The rest of the networking layer (RequestInterceptor, DomainServicesRequestInterceptor) already handles token injection by default, so no further changes are needed there.
Issues found:
- The existing
fetchEnvironmentFeatureFlagstest usesany()forRestParamsand won't catch a future regression whereshouldIgnoreTokenis reintroduced — see inline comment onFeatureFlagProviderTest.kt:142.
Contributor
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
kristofnemere
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.